-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12 Oval hybrids for hybrids MX-Alps footprints #15
Conversation
Thank you for this! Those DRC errors were really bugging me 🙂. |
Looks good! I would like to see a compromise between this and the original version where pin 2 is slotted while pin 1 is not, so that it fixes the drill too close DRC error while still maintaining the positioning benefits of separate holes. |
@WardBenjamin the problem with that is that you'll need to connect both holes with traces as is not possible to do it on the footprint. Either that or as it is now that pops the DRC error |
@dsanchezseco currently, the DRC error only appears on pin 2, and KiCad correctly recognizes pin 1 as being connected to the second PTH (you can see this on the airwire, but I also confirmed on the DRC unconnected report). |
Oops forgot about that, it's been a while since I did it |
@dsanchezseco I'd be happy to make that change and PR to your fork if you'd like, to include that change in this PR |
@WardBenjamin sure, go ahead |
@dsanchezseco is it intentional that holes are only present in one of the two mask layers? That seems like an error to me but just wanted to double check. |
@WardBenjamin My bad, it was an old version, check now. But i think I changed the silks on this version tho |
Looks good, I've got the updates now. I like the silkscreen change as well, good work. |
Thanks! |
@dsanchezseco to verify: are pads 1/2 the same in every footprint? Right now I'm manually checking the diff but if I can just find and replace in every file it'd be done zippy quick. Edit: It looks like they are based on a search; I'll verify visually as well. |
@WardBenjamin yes they are, i'd edited all in the text editor, so it should |
As per the PR I linked, it would be nice to also have these footprints in the KiCad standard library for reuse instead of having them scattered across various Github repositories (to reduce confusion and reduce the barrier to entry). I am willing to help out with this. |
I'm starting an effort to merge the library to the official libraries, I am including these changes. #11 |
Apologize for the ridiculous delay; finally got around to checking pending PRs after too long. |
Sorry for the delay from my side(hahahaha), yeah, it totally makes sense. Now that I assembled one pcb without plate I understand why there was two holes. Thanks for the awesome work! |
This modded footprints have 1 oval hole for each of the switch pads instead of 2 overlaping pads. This also removes the DRC error from Kicad about overlaping pads/drilled holes being to close.
All the modded footprints' pads have the same dimensions as the original overlapping ones.
They look like this.